Ensure copy* intrinsics also perform the static self-init checks #142575
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
oli-obk
added
the
relnotes
|
Adding relnotes as this will break stable code if someone wrote such code in the last year, but there is absolutely no reason to do so, so not even gonna crater it. |
|
It's a soundness fix and is only reachable by having incorrect unsafe code that should be rejected by const eval anyway, right? Then we're justified in "break first, figure out how to migrate smoothly later". |
|
In theory, this could also affect code where there's correct unsafe code in one crate, and there's incorrect safe code in another crate misusing the first crate. |
RalfJung
reviewed
Jun 17, 2025
RalfJung
reviewed
Jun 17, 2025
oli-obk
force-pushed
the
sneaky-self-init
branch
from
16daf7d to
04f835f
Compare
RalfJung
reviewed
Jun 19, 2025
Comment on lines
+1416
to
1422
| // Do our own "do not read from static items while initializing them" checks | ||
| if let Ok((alloc_id, ..)) = self.ptr_try_get_alloc_id(src, size.bytes() as i64) { | ||
| M::before_alloc_read(self, alloc_id)?; | ||
| } | ||
|
|
||
| // For the overlapping case, it is crucial that we trigger the read hook | ||
| // before the write hook -- the aliasing model cares about the order. |
There was a problem hiding this comment.
Suggested change
| // Do our own "do not read from static items while initializing them" checks | |
| if let Ok((alloc_id, ..)) = self.ptr_try_get_alloc_id(src, size.bytes() as i64) { | |
| M::before_alloc_read(self, alloc_id)?; | |
| } | |
| // For the overlapping case, it is crucial that we trigger the read hook | |
| // before the write hook -- the aliasing model cares about the order. | |
| // Trigger read hooks. | |
| // For the overlapping case, it is crucial that we trigger the read hooks | |
| // before the write hook -- the aliasing model cares about the order. | |
| if let Ok((alloc_id, ..)) = self.ptr_try_get_alloc_id(src, size.bytes() as i64) { | |
| M::before_alloc_read(self, alloc_id)?; | |
| } |
The core interpreter doesn't know what the hook does, so it seems odd to refer to to the static item recursion check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #142532
r? @RalfJung